Skip to content

REGR: Bug in indexing with a CategoricalIndex #16123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2017
Merged

REGR: Bug in indexing with a CategoricalIndex #16123

merged 3 commits into from
Apr 26, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Apr 25, 2017 •
edited by jorisvandenbossche
Loading

closes #16115
closes #16131

@jreback jreback added Categorical Categorical Data Type Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version labels Apr 25, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 25, 2017
@codecov
Copy link

codecov bot commented Apr 25, 2017 •
edited
Loading

Codecov Report

Merging #16123 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16123      +/-   ##
==========================================
+ Coverage   90.84%   90.86%   +0.02%     
==========================================
  Files         159      159              
  Lines       50779    50796      +17     
==========================================
+ Hits        46129    46156      +27     
+ Misses       4650     4640      -10
Flag Coverage Δ
#multiple 88.64% <100%> (+0.02%) ⬆️
#single 40.31% <18.18%> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/category.py 98.48% <100%> (+0.04%) ⬆️
pandas/core/dtypes/common.py 93.24% <0%> (-0.39%) ⬇️
pandas/core/series.py 94.98% <0%> (ø) ⬆️
pandas/core/generic.py 91.31% <0%> (ø) ⬆️
pandas/plotting/_converter.py 65.35% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d9861...032232c. Read the comment docs.

@jreback jreback force-pushed the cats branch 2 times, most recently from 4059f4f to 3150ba9 Compare April 25, 2017 11:26
@jreback
Copy link
Contributor Author

jreback commented Apr 25, 2017

@jorisvandenbossche don't merge yet. not 100% happy with this soln.

@jreback jreback merged commit a940868 into pandas-dev:master Apr 26, 2017
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
@jreback @pcluo
REGR: Bug in indexing with a CategoricalIndex (pandas-dev#16123)
331db44 
* REGR: Bug in indexing with a CategoricalIndex

closes pandas-dev#16115

* some cleaning

* BUG: scalar getitem with a CI

closes pandas-dev#16131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Categorical Categorical Data Type Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

BUG: scalar getitem indexing with CategoricalIndex Regression in CategoricalIndex in 0.20rc1
1 participant
@jreback